Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1013: add position field to Employee #2874

Merged
merged 2 commits into from
Apr 4, 2023
Merged

TSK-1013: add position field to Employee #2874

merged 2 commits into from
Apr 4, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Apr 3, 2023 •
edited
Loading

Contribution checklist

Brief description

image

https://front.hc.engineering/workbench/platform/tracker/TSK-1013

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR
TSK-1013: add position field to Employee
55df9fc 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo April 3, 2023 15:23
haiodo
haiodo requested changes Apr 3, 2023
View reviewed changes
Copy link
Member

@haiodo haiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need position in middle panel?

@ThetaDR
TSK-1013: remove position from the middle panel
e429bf2 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo April 4, 2023 06:06
@haiodo haiodo merged commit c6fc35c into main Apr 4, 2023
@haiodo haiodo deleted the TSK-1013 branch April 4, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo