Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1032: add confirmation dialog for projects, fix sprint deleting and allow deleting for Owner or creator only #2964

Merged
merged 6 commits into from
Apr 17, 2023
Merged

TSK-1032: add confirmation dialog for projects, fix sprint deleting and allow deleting for Owner or creator only #2964

merged 6 commits into from
Apr 17, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Apr 12, 2023

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-1032

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR
TSK-1032: add confirmation dialog for projects, fix sprint deleting, …
88245d5 
…allow deleting for Owner or creator only

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
ThetaDR added 4 commits April 13, 2023 12:33
@ThetaDR
TSK-1032: Use generic function for deleting
e29ca88 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1032: Remove trigger when deleting projects and change deletion t…
d704a7b 
…o archiving

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1032: do not show issues from archived projects in MyIssues
4a83cf1 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1032: Ru translation for DeleteProjectConfirm
0a6929f 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo April 14, 2023 14:35
haiodo
haiodo requested changes Apr 14, 2023
View reviewed changes
Copy link
Member

@haiodo haiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have it named archive, and we need unarchive. Please check existing actions for them.

plugins/tracker-assets/lang/en.json Outdated Show resolved Hide resolved
plugins/tracker-resources/src/components/myissues/MyIssues.svelte Show resolved Hide resolved
@ThetaDR
TSK-1032: Redo translations for archiving
7ce20e3 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit e4a53a1 into main Apr 17, 2023
@haiodo haiodo deleted the TSK-1032 branch April 17, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo