Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-964: fit popup when component is loaded. Redo cases when popup doesn't fit due to small window sizes #3022

Merged
merged 1 commit into from
Apr 19, 2023
Merged

TSK-964: fit popup when component is loaded. Redo cases when popup doesn't fit due to small window sizes #3022

merged 1 commit into from
Apr 19, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Apr 19, 2023

Contribution checklist

https://front.hc.engineering/workbench/platform/tracker/TSK-964
image

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR
TSK-964: fit popup when component is loaded. Redo cases when popup do…
4b560c1 
…esn't fit due to small window sizes

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested review from haiodo and BykhovDenis April 19, 2023 16:57
@haiodo haiodo merged commit e7cd05c into main Apr 19, 2023
@haiodo haiodo deleted the TSK-964 branch April 19, 2023 18:18
haiodo pushed a commit that referenced this pull request Apr 20, 2023
@ThetaDR @haiodo
TSK-964: fit popup when component is loaded. Redo cases when popup do…
8412a77 
…esn't fit due to small window sizes (#3022)

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo