Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1047: Fix showing requests after moving staff to another department #3029

Merged
merged 3 commits into from
Apr 21, 2023
Merged

TSK-1047: Fix showing requests after moving staff to another department #3029

merged 3 commits into from
Apr 21, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Apr 20, 2023 •
edited
Loading

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-1047
image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

ThetaDR added 2 commits April 20, 2023 13:48
@ThetaDR
TSK-1047: get requests by staff in department
241c5ff 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1047: format fix
d588a7e 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo
Copy link
Member

haiodo commented Apr 20, 2023

@ThetaDR Let's add UI tests. It is to complicated to verify by eyes.

haiodo
haiodo requested changes Apr 20, 2023
View reviewed changes
Copy link
Member

@haiodo haiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI tests please. :-)

@ThetaDR
TSK-1047: uitest to check request after changing department
500f4a3 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo April 20, 2023 12:48
@haiodo haiodo merged commit 67d361d into main Apr 21, 2023
@haiodo haiodo deleted the TSK-1047 branch April 21, 2023 02:40
@ThetaDR ThetaDR mentioned this pull request Apr 21, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo