Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1064: fix export csv in hr #3032

Merged
merged 2 commits into from
Apr 21, 2023
Merged

TSK-1064: fix export csv in hr #3032

merged 2 commits into from
Apr 21, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Apr 20, 2023

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-1064
image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

ThetaDR added 2 commits April 20, 2023 21:50
@ThetaDR
TSK-1064: make worker in hr monthTableView sortable
fcd7d4b 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1064: add options for separator on export
a3a8345 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit 6356899 into main Apr 21, 2023
@haiodo haiodo deleted the TSK-1064 branch April 21, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo