Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1236: trigger to remove members when deleting department. Fix for already broken departments #3120

Merged
merged 3 commits into from
May 4, 2023
Merged

TSK-1236: trigger to remove members when deleting department. Fix for already broken departments #3120

merged 3 commits into from
May 4, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented May 2, 2023

Contribution checklist

Brief description

image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR ThetaDR marked this pull request as draft May 2, 2023 15:02
@ThetaDR
Copy link
Contributor Author

ThetaDR commented May 2, 2023

Made it draft so i could revisit it tomorrow morning and maybe do some small refactoring

@ThetaDR ThetaDR marked this pull request as ready for review May 3, 2023 12:27
@ThetaDR ThetaDR requested review from BykhovDenis and haiodo May 3, 2023 12:27
ThetaDR added 3 commits May 4, 2023 14:29
@ThetaDR
TSK-1236: trigger to remove members when deleting department. Fix for…
b876d3e 
… already broken departments

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1236: correctly make map of all parents
e178190 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1236: use txMatch
2bf6826 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo May 4, 2023 10:07
@haiodo haiodo merged commit 8d20a51 into main May 4, 2023
@haiodo haiodo deleted the TSK-1236 branch May 4, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo