Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1436: change deleting spaces to removing, add action to move all non-valid requests to correct spaces #3149

Merged
merged 5 commits into from
May 10, 2023
Merged

TSK-1436: change deleting spaces to removing, add action to move all non-valid requests to correct spaces #3149

merged 5 commits into from
May 10, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented May 5, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

ThetaDR added 5 commits May 5, 2023 17:54
@ThetaDR
TSK-1436: add generic action for archiving spaces. Set override where…
1bd0ce6 
… needed

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1436: fix ignoring override due to no match in query
a06fa35 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1436: fix txMatch for Staff mixin
d62884b 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1436: add upgrade action to move requests from non-existing Depar…
d169a73 
…tments. And rename variable

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1436: show only not archived Departments in hr structure
2897493 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested review from haiodo and BykhovDenis May 5, 2023 12:59
@haiodo haiodo merged commit 238f2da into main May 10, 2023
@haiodo haiodo deleted the TSK-1436 branch May 10, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo