Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1387: count cancelled sub-issues as completed #3158

Merged
merged 2 commits into from
May 12, 2023
Merged

TSK-1387: count cancelled sub-issues as completed #3158

merged 2 commits into from
May 12, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented May 10, 2023

Contribution checklist

Brief description

image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/TSK-1387

A list of closed updated issues

ThetaDR added 2 commits May 11, 2023 18:00
@ThetaDR
TSK-1387: count cancelled sub-issues as completed
8803878 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1387: format fix
939f518 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@BykhovDenis BykhovDenis merged commit 11ad105 into main May 12, 2023
@BykhovDenis BykhovDenis deleted the TSK-1387 branch May 18, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThetaDR @haiodo @BykhovDenis