Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBER-279: Total qfix #3281

Merged
merged 1 commit into from
May 30, 2023
Merged

UBER-279: Total qfix #3281

merged 1 commit into from
May 30, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented May 29, 2023

Contribution checklist

Brief description

Fix broken total passing from server to client, add table global total and query total.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo haiodo requested a review from BykhovDenis May 29, 2023 18:20
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo merged commit adda89d into main May 30, 2023
@haiodo haiodo deleted the UBER-279 branch May 30, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants