Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-395: Allow to drop images into description #3382

Merged
merged 1 commit into from
Jun 7, 2023
Merged

UBER-395: Allow to drop images into description #3382

merged 1 commit into from
Jun 7, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Jun 7, 2023

Contribution checklist

Brief description

  • UBER-395: Allow to drop images into description
  • UBER-281: Attached image in text should be removed if Image are deleted.
  • Make attached image on 75% of size.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
UBER-395: Allow to drop images into description
e3feaeb 
* UBER-395: Allow to drop images into description
* UBER-281: Attached image in text should be removed if Image are deleted.
* Make attached image on 75% of size.

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis June 7, 2023 08:57
@BykhovDenis BykhovDenis merged commit aa09fa6 into main Jun 7, 2023
@haiodo haiodo deleted the UBER-395 branch June 7, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @BykhovDenis