Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-537: review support in inbox #3471

Merged
merged 4 commits into from
Jun 29, 2023
Merged

UBER-537: review support in inbox #3471

merged 4 commits into from
Jun 29, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Jun 29, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-537

A list of closed updated issues

ThetaDR added 3 commits June 29, 2023 17:47
@ThetaDR
UBER-537: fix typo
324deb6 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-537: reorder model for correct building
7600d3a 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-537: support reviews in inbox
0cc305f 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested review from haiodo and BykhovDenis June 29, 2023 12:50
@ThetaDR
UBER-537: notification only on new review
c72491f 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@BykhovDenis BykhovDenis merged commit d179189 into main Jun 29, 2023
@BykhovDenis BykhovDenis deleted the UBER-537 branch July 7, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThetaDR @haiodo @BykhovDenis