Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-142: update buttons. Cleaning CSS. #3482

Merged
merged 2 commits into from
Jul 6, 2023
Merged

UBER-142: update buttons. Cleaning CSS. #3482

merged 2 commits into from
Jul 6, 2023

Conversation

SasLord
Copy link
Member

@SasLord SasLord commented Jul 5, 2023 •
edited by huly-github-staging bot
Loading

Contribution checklist

Brief description

Снимок экрана 2023-07-06 в 04 00 46

Fixed paddings: Снимок экрана 2023-07-06 в 02 13 48

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues UBER-142

View in Huly UBERF-2906

SasLord added 2 commits July 6, 2023 02:53
@SasLord
UBER-142: update buttons. Cleaning CSS.
fe054ad 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Fix
8586b4a 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@haiodo haiodo merged commit e7b6522 into main Jul 6, 2023
@haiodo haiodo deleted the fix-uber-142 branch July 6, 2023 07:01
lexiv0re
lexiv0re reviewed Jul 6, 2023
View reviewed changes
packages/ui/src/types.ts
| 'no-border'
| 'transparent'
| 'link'
| 'link-bordered'
| 'dangerous'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SasLord I think negative replaces dangerous now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexiv0re lexiv0re lexiv0re left review comments

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SasLord @haiodo @lexiv0re