Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-609: Fix inbox notification/view for telegram and gmail messages #3518

Merged
merged 2 commits into from
Jul 23, 2023
Merged

UBER-609: Fix inbox notification/view for telegram and gmail messages #3518

merged 2 commits into from
Jul 23, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Jul 21, 2023

Contribution checklist

Brief description

image
image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR
UBER-609: fix no presenter for gmail messages. Fix inbox notification…
7159ce1 
…/view for telegram and gmail messages

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from BykhovDenis July 21, 2023 15:00
BykhovDenis
BykhovDenis requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@BykhovDenis BykhovDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need MessagePresenter

@ThetaDR
UBER-609: remove MessagePresenter
77b8030 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from BykhovDenis July 21, 2023 16:20
@ThetaDR ThetaDR changed the title UBER-609: fix no presenter for gmail messages. Fix inbox notification/view for telegram and gmail messages UBER-609: Fix inbox notification/view for telegram and gmail messages Jul 22, 2023
@BykhovDenis BykhovDenis merged commit e46f67b into main Jul 23, 2023
@BykhovDenis BykhovDenis deleted the UBER-609 branch August 23, 2023 03:32
annano pushed a commit that referenced this pull request Aug 24, 2023
@ThetaDR @annano
UBER-609: Fix inbox notification/view for telegram and gmail messages (…
92c9fa7 
…#3518)

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@whodef whodef mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @BykhovDenis