UBER-532: Copy issue URL works wrong #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BykhovDenis
approved these changes
Jul 28, 2023
| @@ -32,6 +33,8 @@ | |||
| import login from '../plugin' | |||
| import { getInviteLink } from '../utils' | |||
| import InviteWorkspace from './icons/InviteWorkspace.svelte' | |||
|
|
|||
haiodo
reviewed
Jul 28, 2023
| @@ -64,7 +65,9 @@ export async function issueLinkProvider (doc: Doc): Promise<string> { | |||
|
|
|||
| export function generateIssueShortLink (issueId: string): string { | |||
| const location = getCurrentResolvedLocation() | |||
| return `${window.location.protocol}//${window.location.host}/${workbenchId}/${location.path[1]}/${trackerId}/${issueId}` | |||
There was a problem hiding this comment.
It should be more places like this one, so please check for window.location usage.
… set in web, so there is a fallback for web Signed-off-by: Maksim Karmatskikh <mkarmatskih@gmail.com> Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
annano
pushed a commit
that referenced
this pull request
Aug 24, 2023
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… set in web, so there is a fallback for web
Contribution checklist
Brief description
Fix links for the application. Add optional parameter to the metadata.
Checklist
Related issues
A list of closed updated issues