Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZQMS-241: Account for parent classes configurations in list view #3537

Merged
merged 1 commit into from
Aug 1, 2023
Merged

EZQMS-241: Account for parent classes configurations in list view #3537

merged 1 commit into from
Aug 1, 2023

Conversation

lexiv0re
Copy link
Collaborator

Contribution checklist

Brief description

  • Look for the ancestor's configurations if the config for the class is not present

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/EZQMS-241

@lexiv0re
ezqms-241: account for parent classes configurations in list view
1a48223 
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
@lexiv0re lexiv0re requested review from haiodo and BykhovDenis July 31, 2023 18:21
@haiodo haiodo merged commit 6e44e55 into main Aug 1, 2023
@haiodo haiodo deleted the ezqms-241/fix-documents-list-view branch August 1, 2023 07:40
annano pushed a commit that referenced this pull request Aug 24, 2023
@lexiv0re @annano
ezqms-241: account for parent classes configurations in list view (#3537
8cb8db8 
)

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lexiv0re @haiodo