Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-646: clear the class when view is changed to prevent using old one #3541

Merged
merged 1 commit into from
Aug 1, 2023
Merged

UBER-646: clear the class when view is changed to prevent using old one #3541

merged 1 commit into from
Aug 1, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Aug 1, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-646
A list of closed updated issues

@ThetaDR
UBER-646: clear the class when view is changed to prevent using old one
10539f5 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested review from haiodo and BykhovDenis August 1, 2023 10:20
@haiodo haiodo merged commit 3c37669 into main Aug 1, 2023
@haiodo haiodo deleted the UBER-646 branch August 1, 2023 12:40
annano pushed a commit that referenced this pull request Aug 24, 2023
@ThetaDR @annano
UBER-646: clear the class when view is changed to prevent using old o…
9957d1e 
…ne (#3541)

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo