Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-500: Confusing Show More button in table #3590

Merged
merged 2 commits into from
Aug 15, 2023
Merged

UBER-500: Confusing Show More button in table #3590

merged 2 commits into from
Aug 15, 2023

Conversation

mixerka
Copy link
Contributor

@mixerka mixerka commented Aug 15, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

mixerka added 2 commits August 15, 2023 15:48
@mixerka
UBER-500: Fix total count and condition for show more
31690c0 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-500: Fix format
7a4ebba 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@haiodo haiodo merged commit 85d1a95 into main Aug 15, 2023
@haiodo haiodo deleted the UBER-500 branch August 15, 2023 17:11
annano pushed a commit that referenced this pull request Aug 24, 2023
@mixerka @annano
UBER-500: Confusing Show More button in table (#3590)
72ea893 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mixerka @haiodo