Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-600: fix label, fix colours for boolean presenter #3608

Merged
merged 3 commits into from
Aug 19, 2023
Merged

UBER-600: fix label, fix colours for boolean presenter #3608

merged 3 commits into from
Aug 19, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Aug 18, 2023

Contribution checklist

Brief description

image
image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-600
A list of closed updated issues

ThetaDR added 2 commits August 18, 2023 17:45
@ThetaDR
UBER-600: fix label for integration setting
9253314 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
Set correct colours for BooleanTruePresenter
3aa0384 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from BykhovDenis August 18, 2023 12:52
@ThetaDR
UBER-600: make separate label for integration notification setting
41d3c80 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit 6e3ad0e into main Aug 19, 2023
@haiodo haiodo deleted the UBER-600 branch August 19, 2023 09:01
annano pushed a commit that referenced this pull request Aug 24, 2023
@ThetaDR @annano
UBER-600: fix label, fix colours for boolean presenter (#3608)
72a2f08 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThetaDR @haiodo @BykhovDenis