Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-772: require having employee mixin to allow Staff mixin #3618

Merged
merged 2 commits into from
Aug 24, 2023
Merged

UBER-772: require having employee mixin to allow Staff mixin #3618

merged 2 commits into from
Aug 24, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Aug 22, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-772
A list of closed updated issues

@ThetaDR
UBER-772: require having employee mixin to allow Staff mixin
114f124 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo August 22, 2023 18:15
@ThetaDR
UBER-772: check for mixin existing if it has any that extends it
ae8187d 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo August 23, 2023 13:13
@haiodo haiodo merged commit 5ddddd0 into main Aug 24, 2023
@haiodo haiodo deleted the UBER-772 branch August 24, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo