Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBER-770: add custom enum and ref attributes for grouping #3622

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Aug 23, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-770
A list of closed updated issues

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR marked this pull request as ready for review August 25, 2023 07:34
@haiodo haiodo merged commit 15b61ce into main Aug 25, 2023
@haiodo haiodo deleted the UBER-770 branch August 25, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants