Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-816: Fix mentions #3641

Merged
merged 1 commit into from
Aug 30, 2023
Merged

UBER-816: Fix mentions #3641

merged 1 commit into from
Aug 30, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Aug 29, 2023

Contribution checklist

Brief description

  1. Fix mentions
  2. Fix userbox doubling because of multiple accounts
  3. Allow to click on referenced document

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
UBER-816: Fix mentions
b6ed86e 
1. Fix mentions
2. Fix userbox doubling because of multiple accounts
3. Allow to click on referenced document

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested review from aonnikov and BykhovDenis August 29, 2023 17:15
@haiodo haiodo merged commit 93fd82a into main Aug 30, 2023
@haiodo haiodo deleted the UBER-816 branch August 30, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

@aonnikov aonnikov aonnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haiodo @aonnikov @BykhovDenis