Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-839: request the category if it's not in lookup #3679

Merged
merged 3 commits into from
Sep 12, 2023
Merged

UBER-839: request the category if it's not in lookup #3679

merged 3 commits into from
Sep 12, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Sep 11, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-839
A list of closed updated issues

@ThetaDR
UBER-839: request the category if it's not in lookup
42a7b33 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from BykhovDenis September 11, 2023 13:55
BykhovDenis
BykhovDenis reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@BykhovDenis BykhovDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need it? (The same logic on next lines)

@ThetaDR
UBER-839: refactor code
1b5d5b1 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
Copy link
Contributor Author

ThetaDR commented Sep 11, 2023

@BykhovDenis sometimes value.category is undefined and the category is stored in status

@ThetaDR
UBER-839: check for updated category id and get the new object
cdfb6d4 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit 709164c into main Sep 12, 2023
7 checks passed
@haiodo haiodo deleted the UBER-839 branch September 12, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis left review comments

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThetaDR @haiodo @BykhovDenis