Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBER-872: StyleTextEditor: No update when change text in another text #3698

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

mixerka
Copy link
Contributor

@mixerka mixerka commented Sep 14, 2023

Contribution checklist

Brief description

Track if we have unsaved changes and imperative update of content inside an editor

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@aonnikov aonnikov requested a review from haiodo September 15, 2023 03:11
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@haiodo haiodo merged commit 3ca0cff into main Sep 15, 2023
7 checks passed
@haiodo haiodo deleted the UBER-872 branch September 15, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants