Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZQMS-266: Commenting on document #3759

Merged
merged 2 commits into from
Sep 29, 2023
Merged

EZQMS-266: Commenting on document #3759

merged 2 commits into from
Sep 29, 2023

Conversation

annano
Copy link
Contributor

@annano annano commented Sep 28, 2023 •
edited
Loading

Contribution checklist

Brief description

Remove extensions from CollaboratorEditor.svelte

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@annano
EZQMS-266: Commenting on document
e0fd9b2 
Signed-off-by: Anna No <anna.no@xored.com>
aonnikov
aonnikov approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@aonnikov aonnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning up collaborator editor 😄

@annano
fix build
7f15451 
Signed-off-by: Anna No <anna.no@xored.com>
@haiodo haiodo merged commit 5f0ba95 into main Sep 29, 2023
7 checks passed
@haiodo haiodo deleted the ano/move-remove-comments-extensions branch September 29, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonnikov aonnikov aonnikov approved these changes

@haiodo haiodo haiodo approved these changes

@mixerka mixerka Awaiting requested review from mixerka

@lexiv0re lexiv0re Awaiting requested review from lexiv0re

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annano @haiodo @aonnikov