Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-963: Related issues #3773

Merged
merged 5 commits into from
Oct 2, 2023
Merged

UBER-963: Related issues #3773

merged 5 commits into from
Oct 2, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Oct 2, 2023 •
edited
Loading

Contribution checklist

Brief description

  • UBER-963: Related issues
  • UBER-961: Comment content doesn't fit.
  • A bit of scroller and resize performance improvements
image Screenshot 2023-10-02 at 22 45 08 Screenshot 2023-10-02 at 22 45 24 Screenshot 2023-10-02 at 22 45 45 image Screenshot 2023-10-02 at 22 46 21

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo haiodo requested a review from BykhovDenis October 2, 2023 09:26
@haiodo
UBER-963: Related issues
d1adf71 
* UBER-963: Related issues
* UBER-961: Comment content doesn't fit.
* A bit of scroller and resize performance improvements

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
haiodo added 4 commits October 2, 2023 23:15
@haiodo
Review fixes
15ce1a2 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
Review fix
bf1fb3a 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
Svelte check fix
a92987c 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
Fix SelectPopup
8e61ac1 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo merged commit b243532 into main Oct 2, 2023
7 checks passed
@haiodo haiodo deleted the UBER-963 branch October 2, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @BykhovDenis