Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextEditor: Refactor attachments #3833

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

annano
Copy link
Contributor

@annano annano commented Oct 12, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
@aonnikov aonnikov merged commit b439809 into main Oct 16, 2023
7 checks passed
@aonnikov aonnikov deleted the ano/refactor-text-editor-attachments branch October 16, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants