Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-921: Improve full text search #3848

Merged
merged 1 commit into from
Oct 17, 2023
Merged

UBER-921: Improve full text search #3848

merged 1 commit into from
Oct 17, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Oct 17, 2023

Contribution checklist

Brief description

Not fully ideal, since elastic not filter, or I do not understand how to filter, and only move documents with matched fields more in rank.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
UBER-921: Improve full text search
54bd68c 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis October 17, 2023 06:26
@haiodo haiodo merged commit c199ab8 into main Oct 17, 2023
7 checks passed
@haiodo haiodo deleted the UBER-921 branch October 17, 2023 08:22
nestoragent pushed a commit that referenced this pull request Oct 17, 2023
@haiodo @nestoragent
UBER-921: Improve full text search (#3848)
ce96f4d 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Alex Velichko <nestor_007@mail.ru>
nestoragent added a commit that referenced this pull request Oct 17, 2023
@nestoragent
Revert "UBER-921: Improve full text search (#3848)"
eac3304 
This reverts commit ce96f4d.
nestoragent added a commit that referenced this pull request Oct 17, 2023
@nestoragent
Revert "UBER-921: Improve full text search (#3848)"
aea2bfa 
This reverts commit ce96f4d.
nestoragent added a commit that referenced this pull request Oct 17, 2023
@nestoragent
Revert "Revert "UBER-921: Improve full text search (#3848)""
43f0355 
This reverts commit aea2bfa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @BykhovDenis