Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-937: Extensibility changes #3874

Merged
merged 4 commits into from
Oct 24, 2023
Merged

UBER-937: Extensibility changes #3874

merged 4 commits into from
Oct 24, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Oct 24, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
UBER-937: Extensibility changes
da37d1a 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis October 24, 2023 04:50
@haiodo
Fix for pull requests and formatting
cd26115 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
BykhovDenis
BykhovDenis reviewed Oct 24, 2023
View reviewed changes
dev/tool/src/index.ts Outdated Show resolved Hide resolved
packages/core/src/predicate.ts Outdated Show resolved Hide resolved
haiodo added 2 commits October 24, 2023 14:12
@haiodo
Comment fixes
bec9948 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
Fix formatting
b148103 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis October 24, 2023 08:14
@haiodo haiodo merged commit e09bd25 into main Oct 24, 2023
7 checks passed
@haiodo haiodo deleted the UBER-937 branch October 24, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @BykhovDenis