Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-634: focus on SelectPopup #3897

Merged
merged 2 commits into from
Oct 26, 2023
Merged

UBER-634: focus on SelectPopup #3897

merged 2 commits into from
Oct 26, 2023

Conversation

kristina-fefelova
Copy link
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@kristina-fefelova
UBER-634: focus on SelectPopup
62bc8f4 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
BykhovDenis
BykhovDenis previously approved these changes Oct 26, 2023
View reviewed changes
@kristina-fefelova
UBER-634: fix format
7dab5aa 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@haiodo haiodo merged commit 16d3ef1 into main Oct 26, 2023
7 checks passed
@haiodo haiodo deleted the fix-status-focus-634 branch October 26, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

@haiodo haiodo Awaiting requested review from haiodo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristina-fefelova @BykhovDenis @haiodo