Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBERF-4132: Fix unexpected delete of documents in query #3921

Merged
merged 2 commits into from
Oct 31, 2023
Merged

UBERF-4132: Fix unexpected delete of documents in query #3921

merged 2 commits into from
Oct 31, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Oct 31, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo haiodo requested a review from BykhovDenis October 31, 2023 09:06
BykhovDenis
BykhovDenis requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@BykhovDenis BykhovDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix class check

BykhovDenis
BykhovDenis previously approved these changes Oct 31, 2023
View reviewed changes
@haiodo haiodo requested a review from BykhovDenis October 31, 2023 10:30
haiodo added 2 commits October 31, 2023 22:08
@haiodo
UBERF-4132: Fix unexpected delete of documents in query
d8f027d 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
Fix svelte-check
601f7c5 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo merged commit 074dee8 into main Oct 31, 2023
@haiodo haiodo deleted the UBERF-4132 branch October 31, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees

@BykhovDenis BykhovDenis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @BykhovDenis