Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBERF-4348: Mentions. Fix render props types and component props types #4022

Merged
merged 2 commits into from
Nov 21, 2023
Merged

UBERF-4348: Mentions. Fix render props types and component props types #4022

merged 2 commits into from
Nov 21, 2023

Conversation

mixerka
Copy link
Contributor

@mixerka mixerka commented Nov 20, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@mixerka
UBERF-4348: Fix render props types
6a13053 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBERF-4348: Fix format and warning
30cd7ba 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka mixerka requested a review from aonnikov November 20, 2023 19:27
@aonnikov aonnikov merged commit d36dcdc into main Nov 21, 2023
@aonnikov aonnikov deleted the UBERF-4348 branch November 21, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonnikov aonnikov aonnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mixerka @aonnikov