Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZQMS-398: Update CollaborationDiffViewer #4075

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

annano
Copy link
Contributor

@annano annano commented Nov 27, 2023

Contribution checklist

Brief description

  1. Remove diff logics from CollaboratorEditor
  2. Update diff logics in CollaboratorDiffViewer

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
@annano annano merged commit 99a56ba into main Nov 28, 2023
7 checks passed
@annano annano deleted the ano/EZQMS-398/update-collaborator-diff-viewer branch November 28, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants