Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBER-1083: Use hours and minutes to present less than a day durations #4111

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

anotherpit
Copy link
Contributor

Contribution checklist

Brief description

Displays less than a day durations using hours and minutes: 2.5h2h 30m

Screenshot 2023-11-29 at 20 59 24

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
…ests

Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
@haiodo haiodo merged commit e361325 into main Dec 1, 2023
7 checks passed
@haiodo haiodo deleted the UBER-1083 branch December 1, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants