Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-4738: Fix attachments preview #4259

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Dec 25, 2023

Contribution checklist

Brief description

  • Add open action to video files.
  • Open video files in big preview window.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis December 25, 2023 09:48
@haiodo haiodo merged commit 8d7d11a into main Dec 25, 2023
7 checks passed
@haiodo haiodo deleted the UBERF-4738-Fix-attachments branch December 25, 2023 11:44
haiodo added a commit that referenced this pull request Jan 5, 2024
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants