Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-1178: rework indexing fields #4261

Merged
merged 4 commits into from
Dec 27, 2023
Merged

UBER-1178: rework indexing fields #4261

merged 4 commits into from
Dec 27, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Dec 25, 2023 •
edited
Loading

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@ThetaDR ThetaDR requested a review from haiodo December 25, 2023 12:35
@ThetaDR ThetaDR marked this pull request as ready for review December 25, 2023 14:11
@ThetaDR
UBER-1178: rework indexing fields
40b4007 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-1178: remove total for indexer, formatting
ff0c3f8 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-1178: fix ui-test/spreading of the string
90ac0e6 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo
Fix dev env reindex and improve clean logging
4084405 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis December 27, 2023 07:03
@haiodo haiodo merged commit 689e2d4 into main Dec 27, 2023
7 checks passed
@haiodo haiodo deleted the UBER-1178 branch December 27, 2023 07:29
haiodo added a commit that referenced this pull request Jan 5, 2024
@ThetaDR @haiodo
UBER-1178: rework indexing fields (#4261)
b1d6105 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Co-authored-by: Andrey Sobolev <haiodo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonnikov aonnikov aonnikov approved these changes

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThetaDR @haiodo @aonnikov