Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBERF-4360: rewrite chat #4265

Merged
merged 25 commits into from
Jan 11, 2024
Merged

UBERF-4360: rewrite chat #4265

merged 25 commits into from
Jan 11, 2024

Conversation

kristina-fefelova
Copy link
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@kristina-fefelova
UBERF-4360: rewrite chat
167ecd2 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: fix inbox error
794c339 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova kristina-fefelova marked this pull request as draft December 25, 2023 17:07
@kristina-fefelova
UBERF-4360: fix task plugin imports
aea5a20 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: read reactions notifications with message reading
66f3cf6 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: add NotificationType for reactions
b309115 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: add migration
4794ec6 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: use inboxClient and DocNotifyContext
18b8a00 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: merge main
82fcd0b 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: fix types
b8669ae 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: merge main
606ee18 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: merge main
b5dd48a 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: support different types of inbox notifications
99ec85f 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: read viewport messages when new message received
7afe9e7 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: merge main
55f295e 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: fix translation
09d5f29 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: remove create doc channel code
33f0458 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: fix format
de1d298 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: merge main
7e9f687 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova kristina-fefelova marked this pull request as ready for review January 10, 2024 13:00
@kristina-fefelova
UBERF-4360: skip checking notifications in tests
55765b9 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: fix test skipping
471b98e 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: skip chat test
9f17c07 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
haiodo
haiodo reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@haiodo haiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, will try switch locally tomorrow and use before merge.

@haiodo haiodo requested a review from aonnikov January 10, 2024 17:13
@kristina-fefelova
Merge main
be22680 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: remove console.log
147ec26 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: add delete many by query
ae4f013 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-4360: remove extra file
5e173f2 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@haiodo haiodo merged commit 7f6f5e2 into main Jan 11, 2024
7 checks passed
@haiodo haiodo deleted the new-chat-2.0 branch January 11, 2024 14:46
nestoragent pushed a commit that referenced this pull request Jan 12, 2024
@kristina-fefelova @nestoragent
UBERF-4360: rewrite chat (#4265)
f67a98c 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonnikov aonnikov aonnikov approved these changes

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristina-fefelova @haiodo @aonnikov