Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZQMS-529: Added support for primary/positive/negative kinds for CheckBox and RadioButton #4384

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

anotherpit
Copy link
Contributor

@anotherpit anotherpit commented Jan 18, 2024

Contribution checklist

Brief description

Added kind="positive" and kind="negative" for both CheckBox and RadioButton. Need it to properly display trainings' results.

Screenshot 2024-01-18 at 16 46 24 Screenshot 2024-01-18 at 16 46 34 Screenshot 2024-01-18 at 16 47 47 Screenshot 2024-01-18 at 16 47 54

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@anotherpit anotherpit requested review from haiodo and aonnikov January 18, 2024 20:20
aonnikov
aonnikov previously approved these changes Jan 19, 2024
haiodo
haiodo previously approved these changes Jan 19, 2024
…kBox and RadioButton

Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
@aonnikov aonnikov merged commit b4d898b into main Jan 19, 2024
7 checks passed
@aonnikov aonnikov deleted the EZQMS-529 branch January 19, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants