Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBERF-5595: set up attachments sizes #4746

Merged
merged 7 commits into from
Feb 23, 2024
Merged

UBERF-5595: set up attachments sizes #4746

merged 7 commits into from
Feb 23, 2024

Conversation

kristina-fefelova
Copy link
Member

@kristina-fefelova kristina-fefelova commented Feb 21, 2024 •
edited
Loading

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@kristina-fefelova
UBERF-5595: set up attachments sizes
031a5fe 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-5595: provide pixel ratio
a09ffa2 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova kristina-fefelova changed the title UBERF-5595: set up attachments sizes UBERF-5595: set up attachments sizes. Feb 22, 2024
@kristina-fefelova kristina-fefelova changed the title UBERF-5595: set up attachments sizes. UBERF-5595: set up attachments sizes Feb 22, 2024
@kristina-fefelova
UBERF-5595: merge parameters into metadata
ef66f7f 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-5595: merge main
629cb8d 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
haiodo
haiodo previously approved these changes Feb 22, 2024
View reviewed changes
@kristina-fefelova
UBERF-5595: merge main
abf70b1 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
aonnikov
aonnikov previously approved these changes Feb 23, 2024
View reviewed changes
@kristina-fefelova
UBERF-5595: merge main
eb002bb 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova
UBERF-5595: fix svelte-check
27b304e 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@haiodo haiodo merged commit 3e78265 into main Feb 23, 2024
7 checks passed
@haiodo haiodo deleted the chat-attachments-5595 branch February 23, 2024 17:04
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@kristina-fefelova @tjaoc
UBERF-5595: set up attachments sizes (hcengineering#4746)
d59d788 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 5, 2024
@kristina-fefelova @tjaoc
UBERF-5595: set up attachments sizes (hcengineering#4746)
391a8b1 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
tjaoc pushed a commit to tjaoc/huly that referenced this pull request Mar 7, 2024
@kristina-fefelova @tjaoc
UBERF-5595: set up attachments sizes (hcengineering#4746)
6e3164b 
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Tiago Cruz <tcruz@netic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@aonnikov aonnikov aonnikov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristina-fefelova @haiodo @aonnikov