Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS-101: feat(tests): done Modified by filter test #4871

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Conversation

nestoragent
Copy link
Contributor

@nestoragent nestoragent commented Mar 4, 2024

Contribution checklist

Brief description

TESTS-101: feat(tests): done Modified by filter test

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-5877

Signed-off-by: Alex Velichko <alex@hardcoreeng.com>
Signed-off-by: Alex Velichko <alex@hardcoreeng.com>
Signed-off-by: Alex Velichko <alex@hardcoreeng.com>
Signed-off-by: Alex Velichko <alex@hardcoreeng.com>
Signed-off-by: Alex Velichko <alex@hardcoreeng.com>
@nestoragent nestoragent marked this pull request as draft March 4, 2024 19:48
Signed-off-by: Alex Velichko <alex@hardcoreeng.com>
@nestoragent nestoragent marked this pull request as ready for review March 5, 2024 08:38
@nestoragent nestoragent requested a review from haiodo March 5, 2024 08:38
@haiodo haiodo merged commit 049c312 into main Mar 6, 2024
7 checks passed
@haiodo haiodo deleted the feat/tests101 branch March 6, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants