Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(todo): broken context actions #4889

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix(todo): broken context actions #4889

merged 1 commit into from
Mar 6, 2024

Conversation

euaaaio
Copy link
Contributor

@euaaaio euaaaio commented Mar 6, 2024

Contribution checklist

Brief description

  • Fixed broken edit button in context menu. We discussed it with Alice and decided to make it this way.
  • Fixed broken “open in new tab” button in context menu. It just never worked.

Screencast

Screen.Recording.2024-03-06.at.12.26.04.mov

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-5901

Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@euaaaio euaaaio marked this pull request as ready for review March 6, 2024 09:44
@haiodo haiodo merged commit b155bf0 into main Mar 6, 2024
7 checks passed
@haiodo haiodo deleted the fix/todo-context-actions branch March 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants