Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-5886: fix todo reorder on click #4904

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

euaaaio
Copy link
Contributor

@euaaaio euaaaio commented Mar 8, 2024

Contribution checklist

Brief description

The problem was because space property values were incorrectly compared. This caused the todo to be updated every time the todo item was closed.

Screencast

Screen.Recording.2024-03-08.at.13.44.02.mov

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

#4881

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-5924

euaaaio added 3 commits March 8, 2024 12:05
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@euaaaio euaaaio requested a review from haiodo March 8, 2024 10:46
euaaaio added 2 commits March 8, 2024 13:51
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@euaaaio euaaaio marked this pull request as ready for review March 8, 2024 11:36
@haiodo haiodo merged commit 6eefe88 into main Mar 8, 2024
7 checks passed
@haiodo haiodo deleted the fix/todo-reorder-on-click branch March 8, 2024 15:29
haiodo pushed a commit that referenced this pull request Mar 9, 2024
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants