Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): new slots, fixes and improvements #4961

Merged
merged 12 commits into from
Mar 19, 2024

Conversation

euaaaio
Copy link
Contributor

@euaaaio euaaaio commented Mar 14, 2024

Contribution checklist

Brief description

Screencast

Untitled.mov

Another view

image image

Hotkey components

image

Additional changes

  • Fixed a bug when changing the date of workslot, it would glitch due to incorrect calculation of horizontal or vertical positioning
  • Added Hotkey and HotkeyGroup component to the UI library with predefined command, option and shift icons
  • Added styles for uppercase text with medium font weight and 12 font size
  • Added styles for text with medium font weight and 11 font size
  • Changed paddings and icon alignment of ButtonBase to match the design layouts
  • Refactored todos duration calculator. Before, we just summarized the durations of all slots. Now we calculate the duration by considering overlapping slots.
  • Refactored “due date” button. Changed icon and base component.
  • Refactored DateEditor
  • Some UI improvements

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-6003

euaaaio added 3 commits March 14, 2024 11:40
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@euaaaio euaaaio marked this pull request as ready for review March 14, 2024 11:03
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@kristina-fefelova
Copy link
Member

kristina-fefelova commented Mar 15, 2024

I'm not sure, but I kind of want to see these separators aligned
is this correct by design now?

in the tracker we have similar separators and there they seem to be aligned

Screenshot from 2024-03-15 11-26-55

euaaaio added 8 commits March 18, 2024 15:57
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@euaaaio
Copy link
Contributor Author

euaaaio commented Mar 18, 2024

I'm not sure, but I kind of want to see these separators aligned is this correct by design now?

in the tracker we have similar separators and there they seem to be aligned

Done in bb6358d:

image

@kristina-fefelova kristina-fefelova merged commit def45ff into main Mar 19, 2024
7 checks passed
@kristina-fefelova kristina-fefelova deleted the feat/new-planner-slots branch March 19, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants