Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): add action for toggle button #4986

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

euaaaio
Copy link
Contributor

@euaaaio euaaaio commented Mar 15, 2024

Contribution checklist

Brief description

Screencast

Screen.Recording.2024-03-15.at.16.27.46.mov

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-6038

Sorry, something went wrong.

euaaaio added 2 commits March 15, 2024 16:26

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@euaaaio euaaaio marked this pull request as ready for review March 15, 2024 13:46
@kristina-fefelova kristina-fefelova merged commit 6721862 into main Mar 18, 2024
7 checks passed
@kristina-fefelova kristina-fefelova deleted the feat/planner-toggle-nav branch March 18, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants