Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZQMS-1069: Fix request model #6131

Merged
merged 3 commits into from
Jul 27, 2024
Merged

EZQMS-1069: Fix request model #6131

merged 3 commits into from
Jul 27, 2024

Conversation

lexiv0re
Copy link
Collaborator

@lexiv0re lexiv0re commented Jul 24, 2024

  • Changes PersonAccount to Person in Request model because it's currently possible for a single person to have multiple PersonAccounts which leads to issues with request's requested/approval. E.g. the same person might be requested twice and will never be able to provide the second approval.

Related to: https://front.hc.engineering/workbench/platform/tracker/EZQMS-1069

Huly®: UBERF-7664

@lexiv0re lexiv0re requested a review from aonnikov July 24, 2024 16:55
aonnikov
aonnikov previously approved these changes Jul 25, 2024
lexiv0re added 3 commits July 25, 2024 12:38
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
@lexiv0re lexiv0re force-pushed the ezqms-1069/fix-request branch from 8c227ae to c8caa53 Compare July 25, 2024 12:23
@BykhovDenis BykhovDenis merged commit ed903a9 into develop Jul 27, 2024
9 checks passed
@BykhovDenis BykhovDenis deleted the ezqms-1069/fix-request branch July 27, 2024 15:05
haiodo pushed a commit that referenced this pull request Jul 28, 2024
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants