Fixed tests not failing when maxSurviving=0 and typo #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Merged
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when maxSurviving is set to 0, an error will still not be thrown due to this restriction
if ((threshold > 0)in src/main/java/org/pitest/mutationtest/commandline/MutationCoverageReport.java inthrowErrorIfMoreThanMaxSuvivingMutants.We can safely set it to
if ((threshold >= 0)as the default is -1.This should finish the fixes that were started to address this issue: #269.
Also fixed a typo in that method's name changing
throwErrorIfMoreThanMaxSuvivingMutantstothrowErrorIfMoreThanMaxSurvivingMutants.Let me know if any additional information/clarification from me would be helpful.
Thanks!