Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended dataset can be written with invalid data type #629

Open
5 tasks done
rly opened this issue Jun 14, 2021 · 0 comments
Open
5 tasks done

Extended dataset can be written with invalid data type #629

rly opened this issue Jun 14, 2021 · 0 comments
Labels
category: bug errors in the code or code behavior

Comments

@rly
Copy link
Contributor

rly commented Jun 14, 2021

Description

See #609 (comment)

In PyNWB, the "electrodes" table has neurodata_type DynamicTable and is a subgroup of the neurodata_type "NWBFile". It, like other tables, specifies specific VectorData type columns that are not part of the original DynamicTable spec, such as a column for "filtering" that has dtype float. This dtype is not currently used in the building/writing process, so the "filtering" column could be written with a string dtype instead. (This was discovered because the dtype should be a string dtype. See NeurodataWithoutBorders/nwb-schema#478).

The build/write process should check that the dtype of the extended dataset being written is of the correct dtype or can be converted to the correct dtype prior to writing.

Environment

Python Executable: Conda
Python Version: Python 3.8
Operating System: Windows
HDMF Version: dev

Checklist

  • Have you ensured the bug was not already reported ?
  • Have you included a brief and descriptive title?
  • Have you included a clear description of the problem you are trying to solve?
  • Have you included a minimal code snippet that reproduces the issue you are encountering?
  • Have you checked our Contributing document?
@rly rly added the category: bug errors in the code or code behavior label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior
Projects
None yet
Development

No branches or pull requests

1 participant