"Something went wrong" alert needs some work #2314
Assignees
Labels
frontend
Issues related to the frontend
Comments
|
Also I think the message should be "Lost connection to the cluster" because it checks if the browser is online or if healthz endpoint of a cluster responds. |
|
+1 this banner has been really buggy and the message isn't at all visibly traceable to the issue |
|
Got around to checking out the alert component, looks promising. We can keep the width at 100% as before, but I think it would be cleaner and more convenient if the alert was a bit smaller (maybe something closer to this):
@sniok WDYT? |
skoeva
added a commit
that referenced
this issue
Sep 17, 2024
This change addresses issues with accessibility and clarity for the AlertNotification component. This now uses the React Alert component from Material UI and displays a more descriptive error message: "Lost connection to the cluster". Fixes: #2314 Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva
added a commit
that referenced
this issue
Sep 17, 2024
This change addresses issues with accessibility and clarity for the AlertNotification component. This now uses the React Alert component from Material UI and displays a more descriptive error message: "Lost connection to the cluster". Fixes: #2314 Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva
added a commit
that referenced
this issue
Sep 17, 2024
This change addresses issues with accessibility and clarity for the AlertNotification component. This now uses the React Alert component from Material UI and displays a more descriptive error message: "Lost connection to the cluster". Fixes: #2314 Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva
added a commit
that referenced
this issue
Sep 17, 2024
This change addresses issues with accessibility and clarity for the AlertNotification component. This now uses the React Alert component from Material UI and displays a more descriptive error message: "Lost connection to the cluster". Fixes: #2314 Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva
added a commit
that referenced
this issue
Oct 1, 2024
This change addresses issues with accessibility and clarity for the AlertNotification component. This now uses the React Alert component from Material UI and displays a more descriptive error message: "Lost connection to the cluster". Fixes: #2314 Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tested on 0.25.1, disabled the network and this is how it looks like
On wide screens it's way too short
Medium screens, covers the logo
On narrow screens, padding pushes the content all the way to the right
This seems like a good component to use
https://mui.com/material-ui/react-alert/
The text was updated successfully, but these errors were encountered: