Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-catalog: UI papercuts #149

Open
sniok opened this issue Jan 23, 2025 · 4 comments · May be fixed by #150
Open

app-catalog: UI papercuts #149

sniok opened this issue Jan 23, 2025 · 4 comments · May be fixed by #150
Assignees
Labels
app-catalog bug Something isn't working

Comments

@sniok
Copy link
Contributor

sniok commented Jan 23, 2025

Here are some small UI issues found during testing


Settings button 'floats' and is not clear that it is a button

Image


App icon overlaps the text

Image


Hovering install button makes it unreadable

Normal
Image

Hover
Image


Typing into search makes the whole UI 'bounce'

Also note how Categories dropdown rerenders

Recording.2025-01-23.151529.mp4

After clicking on Settings page doesn't have a back button

Image


After clicking on pagination page button focus always goes to the Search field

Image


@sniok sniok added app-catalog bug Something isn't working labels Jan 23, 2025
@skoeva
Copy link
Contributor

skoeva commented Jan 23, 2025

can take a look at these

@skoeva skoeva self-assigned this Jan 23, 2025
@skoeva skoeva linked a pull request Jan 23, 2025 that will close this issue
@skoeva skoeva linked a pull request Jan 23, 2025 that will close this issue
@skoeva
Copy link
Contributor

skoeva commented Jan 24, 2025

I can open an issue for the settings button and the back button, those will need a refactor to get fixed. the rest should be good in #150

@skoeva skoeva mentioned this issue Jan 24, 2025
2 tasks
@vyncent-t
Copy link
Contributor

image

not sure about the part for the box button styling, I had originally used a boxed button but had feedback to change it early on to what it looks like now, maybe we can check in w/ @joaquimrocha to see if we can convert him to be a box enjoyer too 😉

@vyncent-t
Copy link
Contributor

also worth mentioning there has been some shifts for the way styles are done for this plugin, mainly changing away from using the style prop to the sx prop (see the current install button for the list view and then the details view, list view uses sx and details is still on style, causing that color issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-catalog bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants