Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: -logsourcelocations file name differences #297

Closed
maflcko opened this issue Aug 2, 2024 · 10 comments · Fixed by #298 or #315
Closed

cmake: -logsourcelocations file name differences #297

maflcko opened this issue Aug 2, 2024 · 10 comments · Fixed by #298 or #315
Labels
bug Something isn't working

Comments

@maflcko
Copy link

maflcko commented Aug 2, 2024 •
edited
Loading

Is this intentional?

autotools:

  • Linux: [init] [wallet/init.cpp:129] [Construct] Wallet disabled!
  • macos: [init] [wallet/init.cpp:129] [Construct] Wallet disabled!
  • Win: [init] [D:\a\bitcoin-core-with-ci\bitcoin-core-with-ci\src\wallet\init.cpp:129] [Construct] Wallet disabled!

Cmake:

  • Linux: [init] [/home/runner/work/_temp/src/wallet/init.cpp:129] [Construct] Wallet disabled!
  • macos: [init] [/Users/runner/work/bitcoin-core-with-ci/bitcoin-core-with-ci/src/wallet/init.cpp:129] [Construct] Wallet disabled!
  • Win: [init] [D:\a\bitcoin-core-with-ci\bitcoin-core-with-ci\src\wallet\init.cpp:129] [Construct] Wallet disabled!
@hebasto hebasto changed the title -logsourcelocations file name differences cmake: -logsourcelocations file name differences Aug 2, 2024
@fanquake
Copy link

fanquake commented Aug 2, 2024

Looks like that is also introducing a source of non-determinism (for non-guix build binaries)?

@maflcko
Copy link
Author

maflcko commented Aug 2, 2024

Note: I haven't tried guix. Those are the CI-generated binaries. I'll try guix next week, but I expect the result to be the same.

@maflcko
Copy link
Author

maflcko commented Aug 2, 2024

cmake is probably missing the prefix maps: https://stackoverflow.com/a/53848526/2084795

@fanquake
Copy link

fanquake commented Aug 2, 2024

Seems our usage in configure (when using ccache) just wasn't ported over.

@hebasto hebasto mentioned this issue Aug 2, 2024
Merged
@hebasto
Copy link
Owner

hebasto commented Aug 2, 2024

Thanks!

Fixed in #298.

@hebasto hebasto added the bug Something isn't working label Aug 2, 2024
@hebasto hebasto closed this as completed in 30ac8c3 Aug 3, 2024
@maflcko
Copy link
Author

maflcko commented Aug 8, 2024

Note: I haven't tried guix. Those are the CI-generated binaries. I'll try guix next week, but I expect the result to be the same.

Testing now, but it still fails. Please re-open.

@maflcko
Copy link
Author

maflcko commented Aug 8, 2024

Master:

# ./bitcoin-42326b0fa46a/bin/bitcoind -printtoconsole -logsourcelocations -asmap=/tmp/no_file
2024-08-08T14:04:19Z [init/common.cpp:149] [LogPackageVersion] Bitcoin Core version v27.99.0-g42326b0fa46a67ad278cef7709a29feb05ce0110 (release build)
2024-08-08T14:04:19Z [node/chainstatemanager_args.cpp:57] [ApplyArgsManOptions] Script verification uses 7 additional threads
2024-08-08T14:04:19Z [kernel/context.cpp:20] [operator()] Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2024-08-08T14:04:19Z [random.cpp:114] [ReportHardwareRand] Using RdSeed as an additional entropy source
2024-08-08T14:04:19Z [random.cpp:117] [ReportHardwareRand] Using RdRand as an additional entropy source
2024-08-08T14:04:19Z [init/common.cpp:120] [StartLogging] Default data directory /root/.bitcoin
2024-08-08T14:04:19Z [init/common.cpp:121] [StartLogging] Using data directory /root/.bitcoin
2024-08-08T14:04:19Z [init/common.cpp:132] [StartLogging] Config file: /root/.bitcoin/bitcoin.conf (not found, skipping)
2024-08-08T14:04:19Z [common/args.cpp:822] [logArgsPrefix] Command-line arg: asmap="/tmp/no_file"
2024-08-08T14:04:19Z [common/args.cpp:822] [logArgsPrefix] Command-line arg: logsourcelocations=""
2024-08-08T14:04:19Z [common/args.cpp:822] [logArgsPrefix] Command-line arg: printtoconsole=""
2024-08-08T14:04:19Z [init.cpp:1144] [AppInitMain] Using at most 125 automatic connections (524288 file descriptors available)
2024-08-08T14:04:19Z [util/thread.cpp:20] [TraceThread] scheduler thread start
2024-08-08T14:04:19Z [httpserver.cpp:384] [HTTPBindAddresses] Binding RPC on address ::1 port 8332
2024-08-08T14:04:19Z [httpserver.cpp:384] [HTTPBindAddresses] Binding RPC on address 127.0.0.1 port 8332
2024-08-08T14:04:19Z [httprpc.cpp:297] [InitRPCAuthentication] Using random cookie authentication.
2024-08-08T14:04:19Z [rpc/request.cpp:132] [GenerateAuthCookie] Generated RPC authentication cookie /root/.bitcoin/.cookie
2024-08-08T14:04:19Z [rpc/request.cpp:133] [GenerateAuthCookie] Permissions used for cookie: rw-------
2024-08-08T14:04:19Z [httpserver.cpp:488] [StartHTTPServer] Starting HTTP server with 4 worker threads
2024-08-08T14:04:19Z [wallet/load.cpp:53] [VerifyWallets] Using wallet directory /root/.bitcoin/wallets
2024-08-08T14:04:19Z [noui.cpp:57] [noui_InitMessage] init message: Verifying wallet(s)…
2024-08-08T14:04:19Z [noui.cpp:31] [noui_ThreadSafeMessageBox] [error] Could not find asmap file "/tmp/no_file"
Error: Could not find asmap file "/tmp/no_file"
2024-08-08T14:04:19Z [init.cpp:273] [Shutdown] Shutdown: In progress...
2024-08-08T14:04:19Z [util/thread.cpp:22] [TraceThread] scheduler thread exit
2024-08-08T14:04:19Z [init.cpp:387] [Shutdown] Shutdown: done

Cmake:

# ./bitcoin-ec5d1c372b20//bin/bitcoind -printtoconsole -logsourcelocations -asmap=/tmp/no_file 
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/init/common.cpp:149] [LogPackageVersion] Bitcoin Core version v27.99.0-gec5d1c372b20d49147813aa0392195a3642b86a1 (release build)
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/node/chainstatemanager_args.cpp:57] [ApplyArgsManOptions] Script verification uses 7 additional threads
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/kernel/context.cpp:20] [operator()] Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/random.cpp:114] [ReportHardwareRand] Using RdSeed as an additional entropy source
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/random.cpp:117] [ReportHardwareRand] Using RdRand as an additional entropy source
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/init/common.cpp:120] [StartLogging] Default data directory /root/.bitcoin
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/init/common.cpp:121] [StartLogging] Using data directory /root/.bitcoin
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/init/common.cpp:132] [StartLogging] Config file: /root/.bitcoin/bitcoin.conf (not found, skipping)
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/common/args.cpp:822] [logArgsPrefix] Command-line arg: asmap="/tmp/no_file"
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/common/args.cpp:822] [logArgsPrefix] Command-line arg: logsourcelocations=""
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/common/args.cpp:822] [logArgsPrefix] Command-line arg: printtoconsole=""
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/init.cpp:1151] [AppInitMain] Using at most 125 automatic connections (524288 file descriptors available)
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/util/thread.cpp:20] [TraceThread] scheduler thread start
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/httpserver.cpp:384] [HTTPBindAddresses] Binding RPC on address ::1 port 8332
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/httpserver.cpp:384] [HTTPBindAddresses] Binding RPC on address 127.0.0.1 port 8332
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/httprpc.cpp:297] [InitRPCAuthentication] Using random cookie authentication.
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/rpc/request.cpp:132] [GenerateAuthCookie] Generated RPC authentication cookie /root/.bitcoin/.cookie
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/rpc/request.cpp:133] [GenerateAuthCookie] Permissions used for cookie: rw-------
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/httpserver.cpp:488] [StartHTTPServer] Starting HTTP server with 4 worker threads
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/wallet/load.cpp:53] [VerifyWallets] Using wallet directory /root/.bitcoin/wallets
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/noui.cpp:57] [noui_InitMessage] init message: Verifying wallet(s)…
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/noui.cpp:31] [noui_ThreadSafeMessageBox] [error] Could not find asmap file "/tmp/no_file"
Error: Could not find asmap file "/tmp/no_file"
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/init.cpp:273] [Shutdown] Shutdown: In progress...
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/util/thread.cpp:22] [TraceThread] scheduler thread exit
2024-08-08T14:04:35Z [/distsrc-base/distsrc-ec5d1c372b20-x86_64-linux-gnu/src/init.cpp:387] [Shutdown] Shutdown: done

@hebasto hebasto reopened this Aug 8, 2024
@hebasto
Copy link
Owner

hebasto commented Aug 8, 2024

Please re-open.

Re-opened.

@hebasto hebasto mentioned this issue Aug 8, 2024
Merged
@hebasto
Copy link
Owner

hebasto commented Aug 8, 2024

Note: I haven't tried guix. Those are the CI-generated binaries. I'll try guix next week, but I expect the result to be the same.

Testing now, but it still fails. Please re-open.

Fixed in #315.

@maflcko
Copy link
Author

maflcko commented Aug 20, 2024

Checked that guix builds work fine now:

# ./bitcoin-autotools/bin/bitcoind  -printtoconsole -logsourcelocations -asmap=/tmp/no_file  
2024-08-20T13:24:25Z [init/common.cpp:149] [LogPackageVersion] Bitcoin Core version v27.99.0-gee367170cb2acf82b6ff8e0ccdbc1cce09730662 (release build)
2024-08-20T13:24:25Z [node/chainstatemanager_args.cpp:57] [ApplyArgsManOptions] Script verification uses 7 additional threads
2024-08-20T13:24:25Z [kernel/context.cpp:20] [operator()] Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2024-08-20T13:24:25Z [random.cpp:114] [ReportHardwareRand] Using RdSeed as an additional entropy source
2024-08-20T13:24:25Z [random.cpp:117] [ReportHardwareRand] Using RdRand as an additional entropy source
2024-08-20T13:24:25Z [init/common.cpp:120] [StartLogging] Default data directory /root/.bitcoin
2024-08-20T13:24:25Z [init/common.cpp:121] [StartLogging] Using data directory /root/.bitcoin
2024-08-20T13:24:25Z [init/common.cpp:132] [StartLogging] Config file: /root/.bitcoin/bitcoin.conf (not found, skipping)
2024-08-20T13:24:25Z [common/args.cpp:825] [logArgsPrefix] Command-line arg: asmap="/tmp/no_file"
2024-08-20T13:24:25Z [common/args.cpp:825] [logArgsPrefix] Command-line arg: logsourcelocations=""
2024-08-20T13:24:25Z [common/args.cpp:825] [logArgsPrefix] Command-line arg: printtoconsole=""
2024-08-20T13:24:25Z [init.cpp:1158] [AppInitMain] Using at most 125 automatic connections (524288 file descriptors available)
2024-08-20T13:24:25Z [util/thread.cpp:20] [TraceThread] scheduler thread start
2024-08-20T13:24:25Z [httpserver.cpp:384] [HTTPBindAddresses] Binding RPC on address ::1 port 8332
2024-08-20T13:24:25Z [httpserver.cpp:384] [HTTPBindAddresses] Binding RPC on address 127.0.0.1 port 8332
2024-08-20T13:24:25Z [httprpc.cpp:297] [InitRPCAuthentication] Using random cookie authentication.
2024-08-20T13:24:25Z [rpc/request.cpp:132] [GenerateAuthCookie] Generated RPC authentication cookie /root/.bitcoin/.cookie
2024-08-20T13:24:25Z [rpc/request.cpp:133] [GenerateAuthCookie] Permissions used for cookie: rw-------
2024-08-20T13:24:25Z [httpserver.cpp:488] [StartHTTPServer] Starting HTTP server with 4 worker threads
2024-08-20T13:24:25Z [wallet/load.cpp:53] [VerifyWallets] Using wallet directory /root/.bitcoin/wallets
2024-08-20T13:24:25Z [noui.cpp:57] [noui_InitMessage] init message: Verifying wallet(s)…
2024-08-20T13:24:25Z [noui.cpp:31] [noui_ThreadSafeMessageBox] [error] Could not find asmap file "/tmp/no_file"
Error: Could not find asmap file "/tmp/no_file"
2024-08-20T13:24:25Z [init.cpp:273] [Shutdown] Shutdown: In progress...
2024-08-20T13:24:25Z [util/thread.cpp:22] [TraceThread] scheduler thread exit
2024-08-20T13:24:25Z [init.cpp:387] [Shutdown] Shutdown: done

# ./bitcoin-cmake/bin/bitcoind  -printtoconsole -logsourcelocations -asmap=/tmp/no_file
2024-08-20T13:24:34Z [init/common.cpp:149] [LogPackageVersion] Bitcoin Core version v27.99.0-g3fbd65d8a8b0e781695628b08e166e73cc220956 (release build)
2024-08-20T13:24:34Z [node/chainstatemanager_args.cpp:57] [ApplyArgsManOptions] Script verification uses 7 additional threads
2024-08-20T13:24:34Z [kernel/context.cpp:20] [operator()] Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2024-08-20T13:24:34Z [random.cpp:114] [ReportHardwareRand] Using RdSeed as an additional entropy source
2024-08-20T13:24:34Z [random.cpp:117] [ReportHardwareRand] Using RdRand as an additional entropy source
2024-08-20T13:24:34Z [init/common.cpp:120] [StartLogging] Default data directory /root/.bitcoin
2024-08-20T13:24:34Z [init/common.cpp:121] [StartLogging] Using data directory /root/.bitcoin
2024-08-20T13:24:34Z [init/common.cpp:132] [StartLogging] Config file: /root/.bitcoin/bitcoin.conf (not found, skipping)
2024-08-20T13:24:34Z [common/args.cpp:825] [logArgsPrefix] Command-line arg: asmap="/tmp/no_file"
2024-08-20T13:24:34Z [common/args.cpp:825] [logArgsPrefix] Command-line arg: logsourcelocations=""
2024-08-20T13:24:34Z [common/args.cpp:825] [logArgsPrefix] Command-line arg: printtoconsole=""
2024-08-20T13:24:34Z [init.cpp:1158] [AppInitMain] Using at most 125 automatic connections (524288 file descriptors available)
2024-08-20T13:24:34Z [util/thread.cpp:20] [TraceThread] scheduler thread start
2024-08-20T13:24:34Z [httpserver.cpp:384] [HTTPBindAddresses] Binding RPC on address ::1 port 8332
2024-08-20T13:24:34Z [httpserver.cpp:384] [HTTPBindAddresses] Binding RPC on address 127.0.0.1 port 8332
2024-08-20T13:24:34Z [httprpc.cpp:297] [InitRPCAuthentication] Using random cookie authentication.
2024-08-20T13:24:34Z [rpc/request.cpp:132] [GenerateAuthCookie] Generated RPC authentication cookie /root/.bitcoin/.cookie
2024-08-20T13:24:34Z [rpc/request.cpp:133] [GenerateAuthCookie] Permissions used for cookie: rw-------
2024-08-20T13:24:34Z [httpserver.cpp:488] [StartHTTPServer] Starting HTTP server with 4 worker threads
2024-08-20T13:24:34Z [wallet/load.cpp:53] [VerifyWallets] Using wallet directory /root/.bitcoin/wallets
2024-08-20T13:24:34Z [noui.cpp:57] [noui_InitMessage] init message: Verifying wallet(s)…
2024-08-20T13:24:34Z [noui.cpp:31] [noui_ThreadSafeMessageBox] [error] Could not find asmap file "/tmp/no_file"
Error: Could not find asmap file "/tmp/no_file"
2024-08-20T13:24:34Z [init.cpp:273] [Shutdown] Shutdown: In progress...
2024-08-20T13:24:34Z [util/thread.cpp:22] [TraceThread] scheduler thread exit
2024-08-20T13:24:34Z [init.cpp:387] [Shutdown] Shutdown: done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@fanquake @maflcko @hebasto