New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional functionality for Transformation #76

Closed

PvdBerg1998 opened this issue Jul 27, 2019 · 0 comments · Fixed by #78

Labels

feature good first issue improvement

Milestone

Contributor

PvdBerg1998 commented Jul 27, 2019 •

edited

Loading

Possible improvements:

Creation from nalgebra Matrix
Convertion to nalgebra Matrix or f32 array representation
Switch to Matrix3?
Use Affine2 instead of Matrix3 since it more accurately represents the data (invertible translation, rotation, (non uniform) scaling): https://www.nalgebra.org/points_and_transformations/#transformations
Applying to vectors/points directly (also possible via first converting to nalgebra Matrix)

hecrj added feature improvement good first issue labels

PvdBerg1998 mentioned this issue

Add Transformation::transform_point/vector and inverse. Add From/Into… #78

Merged

hecrj closed this as completed in #78

hecrj added this to the 0.4.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment